Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade IRRemoteESP8266 to support core 2.4.0 (IRremoteESP8266 1.2.0 does not compile with core 2.4.0) #688

Closed
s0170071 opened this issue Jan 10, 2018 · 4 comments
Labels
Type: Bug Considered a bug
Milestone

Comments

@s0170071
Copy link
Contributor

... it cannot find the min() / max() functions. The bug is in the library and it is already fixed in the current verision as far as I can tell.
The source of the error is that as of core 2.4.0 min() and max() functions force to have arguments of identical type which may require some casting.
As this prevents compilation I suggest to update to the current version the library.
https://github.com/markszabo/IRremoteESP8266

@Grovkillen Grovkillen added Type: Bug Considered a bug Category: Core related Related to the (external) core libraries labels Jan 10, 2018
@s0170071
Copy link
Contributor Author

@Grovkillen: its not really core related, more core triggered... sort of.
See devyte post here: esp8266/Arduino#398
Solution is to update the lib.

@Grovkillen
Copy link
Member

I hear ya, I put it as only bug then :)

@Grovkillen Grovkillen removed the Category: Core related Related to the (external) core libraries label Jan 10, 2018
@psy0rz psy0rz changed the title IRremoteESP8266 1.2.0 does not compile with core 2.4.0 Upgrade IRRemoteESP8266 to support core 2.4.0 (IRremoteESP8266 1.2.0 does not compile with core 2.4.0) Jan 10, 2018
@psy0rz psy0rz added this to the 2.1.0 milestone Jan 10, 2018
@tarkan123
Copy link

I have integrated IRremoteESP8266 2.3.1 in to the latest Mega files (locally), making the necessary changes to the plugin files. Compiles successully.

However, since version 1.2.0 IRremoteESP8266, the number of supported protocols has grown, so not sure how this will impact memory and resources within ESPeasy.

@Grovkillen
Copy link
Member

Seems to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Considered a bug
Projects
None yet
Development

No branches or pull requests

4 participants