[Mega] Allow compile with 2.4.0 core library #772
Conversation
Last few days, lots of issues reported by users who installed the 2.4.0 core libraries. e.g. letscontrolit#769 and letscontrolit#763 It appeared the default PlatformIO Espressif 8266 1.6.0 libs now include the 2.4.0 core libraries. Now I have to find a way to get my own environment back to the 2.3.0 core libs and see how I can get PlatformIO Espressif 8266 library back to version 1.5.0
|
Hmmm it appears the PlatformIO libraries are really hard to grasp (may also indicate the state of my mind)
So that may explain why people all of a sudden unknowingly try to build with the 2.4.0 core libs. Maybe we should re-consider staying to 2.3.0 for the 2.0 branch. Edit: Edit2: |
A partial cherrypick of letscontrolit#772, to make merging easier. Just some simple patches on the use of min() and max() in the library to allow it to compile using the 2.4.0 core lib. Actual use of this core lib is still prohibited by the check in ESPEasy.ino.
|
It took me also a long time how to let platform IO use the 2.3.0 libraries. You now force platform I/O to use a specific version. Normally it uses the staging version from github |
|
When compiling with different core versions, I found it to be good practice to use multiple instances of the Arduino portable IDE - each with a different core. Another thing I observed: |
|
@s0170071 I agree it adds some significant speed improvements. I will change the platformio.ini file and see what happens. |
|
The "garbage" on v2.0 is most likely linked to the chunked transfer. That is what caused it in mega. |
|
Every update will lead to a "ERR_INVALID_CHUNKED_ENCODING" page in Chrome. So that bug may seem to be fixed. |
|
Can someone explain me the difference between the Mega and V2.0 branch and why they coexist and development takes places on 2 branches? |
|
@Grovkillen is this at the wiki yet? basically: mega=cutting edge v2.0=next stable release (only fixes, no new features) |
|
Not yet. Will try to do it this evening.
Den 25 jan. 2018 15:48 skrev "DatuX" <notifications@github.com>:
… Merged #772 <#772>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#772 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZeBYvqTHrl7vPwPU8D0c0l-jlkGSOIPks5tOJQlgaJpZM4RsEb7>
.
|
|
I've added a box in the "Loading firmware" paragraph on the intro page for clarification: |
* [V2.0] Allow IRremoteESP8266 to be build with core 2.4.0 A partial cherrypick of #772, to make merging easier. Just some simple patches on the use of min() and max() in the library to allow it to compile using the 2.4.0 core lib. Actual use of this core lib is still prohibited by the check in ESPEasy.ino. * [core 2.3.0] Force PlatformIO to use the 2.3.0 core libs This update forces the PlatformIO environment to load the 1.5.0 version of espressif8266@1.5.0, which uses Core 2.3.0
Last few days, lots of issues reported by users who installed the 2.4.0 core libraries.
e.g. #769 and #763
This fixes #725 and thus makes #688 less urgent.
It appeared the default PlatformIO Espressif 8266 1.6.0 libs now include the 2.4.0 core libraries.
Now I have to find a way to get my own environment back to the 2.3.0 core libs and see how I can get PlatformIO Espressif 8266 library back to version 1.5.0
One of the main issues is the change in implementation for min() and max().