Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLX90614 and ADS1115 plugins #15

Closed
wants to merge 1 commit into from

Conversation

lindeger
Copy link
Contributor

@lindeger lindeger commented Jan 4, 2016

MLX90614 is a IR temperature sensor
P024 gives the temperature of the object seen by the sensor
P027 give the ambient temperature of the sensor
ADS1115 is a 16 bit AD converter
P025 is the ADS1115 used with the Sharp Dust sensor

MLX90614 is a IR temperature sensor
P024 gives the temperature of the object seen by the sensor
P027 give the ambient temperature of the sensor
ADS1115 is a 16 bit AD converter
P025 is the ADS1115 used with the Sharp Dust sensor
@ghost
Copy link

ghost commented Jan 5, 2016

Hi there,

Thanks for your contribution to the project! Would be nice to add support for these devices. But I have a few questions/remarks on this development:

MLX90614

  1. Any specific reason to provide two plugins for the same device?

A plugin can return up to 4 variables, so I guess both IR and ambient temperatures could be done with a single plugin.

Or maybe add a selection dropdown to select between reading IR or ambient temperature

If you need to send them to the controller as individual values, you can load the plugin twice and select the value that you want for each task.

Could you try to combine plugin 024 and 027 into a single plugin?

ADS1115

We should also rethink the dust sensor solution which is actually just an extension to any ADC plugin (like the internal ADC, the PCF8591 and now also the ADS1115)
We also have the dust sensor on the internal ADC and I think we should avoid getting additional Dust plugins for each possible ADC chip to be supported in the future.

Maybe we should add options in the webgui to select some action before/after reading the port and have a selection for 'oversampling'.

Then we could handle the ADS1115 with a single plugin and we could also make the existing Dust plugin P018 obsolete

Or we could make ONE new dust plugin where the ADC to be used can be selected with a dropdown.

Please let me know if you need help on this or have different proposals!

You may ask why all this is important?

  1. Maximum number of plugins is limited within the ESP Easy framework.
  2. Each additional plugin costs both RAM and Flash space.
  3. We like to keep as many plugins available without building custom firmware editions.

@lindeger
Copy link
Contributor Author

lindeger commented Jan 5, 2016

Van: mvdbro [mailto:notifications@github.com]
Verzonden: dinsdag 5 januari 2016 14:06
Aan: ESP8266nu/ESPEasy
CC: lindeger
Onderwerp: Re: [ESPEasy] MLX90614 and ADS1115 plugins (#15)

Hi there,

Thanks for your contribution to the project! Would be nice to add support for these devices. But I have a few questions/remarks on this development:

MLX90614

  1. Any specific reason to provide two plugins for the same device?

A plugin can return up to 4 variables, so I guess both IR and ambient temperatures could be done with a single plugin.

Or maybe add a selection dropdown to select between reading IR or ambient temperature

If you need to send them to the controller as individual values, you can load the plugin twice and select the value that you want for each task.

Could you try to combine plugin 024 and 027 into a single plugin?

The port value is used as an offset to the default address (5Ah)
What would you advise?

  1.   Both variables in a single plugin
    
  2.   A dropdown to select the value
    

ADS1115

We should also rethink the dust sensor solution which is actually just an extension to any ADC plugin (like the internal ACD, the PCF8591 and now also the ADS1115)
We also have the dust sensor on the internal ADC and I think we should avoid getting additional Dust plugins for each possible ADC chip to be supported in the future.

Maybe we should add options in the webgui to select some action before/after reading the port and have a selection for 'oversampling'.

Then we could handle the ADS1115 with a single plugin and we could also make the existing Dust plugin P018 obsolete

Or we could make ONE new dust plugin where the ADC to be used can be selected with a dropdown.

Please let me know if you need help on this or have different proposals!

You may ask why all this is important?

  1. Maximum number of plugins is limited within the ESP Easy framework.
  2. Each additional plugin costs both RAM and Flash space.
  3. We like to keep as many plugins available without building custom firmware editions.

I would like to built a ADC plugin with the option to choose a GPIO for a pulse, the current dust version acts like this when the GPIO is not chosen.
But I also would like to have an input field for the length of the pulse and the polarity.
I don’t know if it is sufficient for every purpose to only give the time before reading the ADC and finish the pulse after reading.
The dust sensor uses 280 microseconds, but a gas sensor needs a heating time of about 3 minutes before accurate readings.

I don’t know what the best way is to realize these extra input fields.

Please let me know what the best option is and help me with extra input fields.

With regards,

Ger van der Linde


Reply to this email directly or #15 (comment) view it on GitHub. https://github.com/notifications/beacon/AH5fjmLiPaEddSEs6gM1Q6qT9YVc4ZZcks5pW7dNgaJpZM4G-buG.gif

@ghost
Copy link

ghost commented Jan 5, 2016

For now, I suggest to combine plugin 24/27 by adding a dropdown to select between one of the two possible readings. Use plugin number 024 for this. If you need both values towards the controller, you could use two tasks, one for each value. Domoticz will not support two temperature values on one IDX anyway... There's no sensor type for that.

I would also prefer to have the generic ADS1115 support as plugin 025.

Then try to extend the existing plugin 018 to have a selection between all currently available ADC options. I think this plugin mainly needs an additional "Select ADC" dropdown with the options "Build-in", "PCF8591" and "ADS1115".

So then we have two new and one updated plugin. I think it's best to create a pull request for each one of them individually.

The gas sensors that I known off have preheating times of 24-48 hours. I think it's best to keep them permanently active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant