[HTTP Advanced] Do not percent-encode body (#1306) #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replaced values are percent-encoded, which causes issues like described here: letscontrolit#1306
… into bugfix/controller_http_advanced
For some strange reason.... Build log: ``` $ PLATFORMIO_BUILD_FLAGS="-D CONTINUOUS_INTEGRATION" platformio run -e $ENV Processing minimal_core_242_ESP8266_1M_OTA (platform: https://github.com/TD-er/platform-espressif8266.git#patch/v1.8.0_Puya; board: esp01_1m; framework: arduino) -------------------------------------------------------------------------------- Platform Manager: Installing git+https://github.com/TD-er/platform-espressif8266.git#patch/v1.8.0_Puya git version 2.27.0 Cloning into '/home/travis/.platformio/.cache/tmp/pkg-installing-aktun99x'... Platform Manager: espressif8266 @ 1.8.0+sha.9ffc857 has been installed! The platform 'https://github.com/TD-er/platform-espressif8266.git#patch/v1.8.0_Puya' has been successfully installed! The rest of the packages will be installed later depending on your build environment. Tool Manager: Installing toolchain-xtensa @ ~1.40802.0 Downloading... Unpacking... Tool Manager: toolchain-xtensa @ 1.40802.0 has been installed! Tool Manager: Installing framework-arduinoespressif8266 @ 2.20402.4-puya Tool Manager: Warning! More than one package has been found by framework-arduinoespressif8266 @ 2.20402.4-puya requirements: - platformio/framework-arduinoespressif8266 @ 3.20704.0 - jason2866/framework-arduinoespressif8266 @ 2.7.4.1 Tool Manager: Please specify detailed REQUIREMENTS using package owner and version (showed above) to avoid name conflicts Error: Could not find the package with 'framework-arduinoespressif8266 @ 2.20402.4-puya' requirements for your system 'linux_x86_64' The command "PLATFORMIO_BUILD_FLAGS="-D CONTINUOUS_INTEGRATION" platformio run -e $ENV" exited with 1. ``` Maybe @Jason2866 does have an idea?
Allowing to use variables in the URL
Does save extra update step, as ESP32 already demands PIO 5 as minimum version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replaced values are percent-encoded, which causes issues like described here: #1306
Fixes: #1306