Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P110] Move P133 VL53L0X from PluginPlayground to main repository #3493

Conversation

tonhuisman
Copy link
Contributor

Move Plugin 133 VL53L0X from PluginPlayground to main repository (TESTING)

  • Adjusted to current Plugin standards
  • Enable multiple instances by refactoring and implementing PluginStructs
  • Added documentation (new category: Distance)

As requested in the forum

NB: Not enabled in the TESTING set as then it won't fit in most builds. When needed a custom build could be configured.

@TD-er
Copy link
Member

TD-er commented Mar 7, 2021

Do you want it to be merged, or investigate the reported issue on a similar sensor not working with this plugin?

@tonhuisman
Copy link
Contributor Author

I suspect that the chip ID doesn't match the one(s) checked in the driver during init.
I'll add some logging there if it doesn't match, that should help finding the cause quicker.

@TD-er
Copy link
Member

TD-er commented Mar 7, 2021

So no merge yet?

@tonhuisman
Copy link
Contributor Author

Let's wait a couple of days, I won't be able to fix this tonight 😉

lib/VL53L0X/VL53L0X.cpp Outdated Show resolved Hide resolved
@TD-er
Copy link
Member

TD-er commented Mar 27, 2021

Can you resolve the merge conflicts?

@TD-er
Copy link
Member

TD-er commented Apr 5, 2021

So it is now ready to be merged?

@tonhuisman
Copy link
Contributor Author

So it is now ready to be merged?

Yes. (Please 😃)

@TD-er TD-er merged commit 7ef72e9 into letscontrolit:mega Apr 5, 2021
@TD-er
Copy link
Member

TD-er commented Apr 5, 2021

You will include it in the 'max' build?

@tonhuisman tonhuisman deleted the feature/P110_VL53L0X_move_from_pluginplayground branch April 5, 2021 19:16
@tonhuisman
Copy link
Contributor Author

Yes, of course, I'll add all from P110 to P125 already, as that's currently the max. nr of plugins supported by the 'max' build. (tough there are some numbers still missing from the range)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants