This plugin is tested and working good.

[tedenda]

@Grovkillen It will now be a standard plugin.

[Grovkillen]

@tedenda Good, it's a solid plugin! 👍

[JK-de]

Should be the naming a little bit more descriptive like "Gases - Senseair CO2" ?

[tedenda]

Yes, that's a good idea. @Grovkillen What should the name be? Mvh Daniel Tedenljung

…

On 11 juli 2017 08:42 +0200, Jochen Krapf ***@***.***>, wrote: Should be the naming a little bit more descriptive like "Gases - Senseair CO2" ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Grovkillen]

I think @jkDesignDE idea is great. Lets use that @tedenda
"NDIR CO2 Sensor MH-Z19 [TESTING]" the P049 should also be renamed.

"Gases - MH-Z19 CO2"

[Grovkillen]

Or is "Gases - CO2 Senseair" and "Gases - CO2 MH-Z19" more generic and place the plugins more alphabetically in the list. More types of gases would otherwise get in between.

[tedenda]

Let's go with the last one.

…

On 11 juli 2017 09:10 +0200, Grovkillen ***@***.***>, wrote: Or is "Gases - CO2 Senseair" and "Gases - CO2 MH-Z19" more generic and place the plugins more alphabetically in the list. More types of gases would otherwise get in between. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[TD-er]

I am using this, but I wouldn't say it is working "good".
Currently the initialisation leaves the "Automatic Base Calibration" (ABC) enabled.
This will lead to reset the base calibration value to the lowest experienced value in the past 24h.
When a room is not ventilated enough in a day, the next day will be completely off.
This ABC should be disabled for normal use and only enabled when enough ventilated (e.g. when lowest value experienced was plausible for good ventilation, or extremely bad calibration value during the day, for example about an hour at near constant value)

I can also make a separate issue for it, when desired.

[Grovkillen]

What sensor are you using?

[TD-er]

MH-Z19 CO2 sensor.
I opened a new issue about it here: #466

[infernix]

Working as intended by manufacturer qualifies as "good" in my book.

[Grovkillen]

This plugin is referring to the top quality sensor(s) from Senseair. "P052_SenseAir.ino".

The MH-Z19 is a bad version of their S8. The ABC calibration is not comparable whatsoever.

[infernix]

I'm not disagreeing. I'm saying it's up to the user to decide if he uses a high quality or mediocre sensor; when it's working as intended from ESPEasys point of view (e.g. the code is valid) it can leave TESTING, right? So in that sense MH-Z19 should be fine as a standard plugin as well?

[TD-er]

@Grovkillen
Oh sorry, I guess I mixed up the threads/commit tabs then.
I was perhaps confused by the relabeling discussion of the MH-Z19 sensor mentioned here also.

Just to be sure... do you have a link to the "not bad version CO2 sensor" this plugin is about? ;)
Never mind, found it... http://www.senseair.com/products/oem-modules/senseair-s8/

[Grovkillen]

@TD-er good you found it.

[Grovkillen]

@infernix that is probably right. :) I don't have the MH-Z19 myself but as you say, it is good to have options as a user. I agree that technical wise your plugin is stable and should leave TESTING as well.