Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Add ESP32 IRExt with Ethernet build environments #4437

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Dec 27, 2022

From a Forum request

Features:

  • Add IRExt with Ethernet builds:
    • custom_IR_ESP32_4M316k_ETH
    • custom_IR_ESP32_16M8M_LittleFS_ETH
    • normal_ESP32_IRExt_4M316k_ETH
  • Prepared also some more IRExt/ETH builds, but not activated yet (to limit PR build-times):
    • collection_A_ESP32_IRExt_4M316k_ETH .. collection_F_ESP32_IRExt_4M316k_ETH, energy_ESP32_IRExt_4M316k_ETH, display_ESP32_IRExt_4M316k_ETH, climate_ESP32_IRExt_4M316k_ETH and neopixel_ESP32_IRExt_4M316k_ETH
  • Mark used GPIO pin as unusable if Preferred network medium is Ethernet, and Ethernet Clock is configured using that GPIO

@ironataerial
Copy link

ironataerial commented Dec 29, 2022

ESP_Easy_mega_20221227_normal_ESP32_IRExt_4M316k_ETH IR - Tx and Rx show up ok on Device / Pulldown
But
ESP_Easy_custom_20221227_custom_ESP32_IRExt_4M316k_ETH seesm to be missing the IR (?)

-D

@TD-er
Copy link
Member

TD-er commented Dec 29, 2022

Then you can add the P016 and P035 plugins to the https://github.com/letscontrolit/ESPEasy/blob/mega/tools/pio/pre_custom_esp32.py

The reason there is a custom_IR env is because otherwise the IR libraries are in the lib_ignore list.
Right now we only have a single pre_custom_esp32.py file and if we add those IR plugins to it, it will fail builds for the non-IR custom builds.

@TD-er TD-er merged commit 32533a3 into letscontrolit:mega Jan 26, 2023
@tonhuisman tonhuisman deleted the feature/Build-add-ir-with-ethernet-esp32-builds branch January 26, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants