[Internal temp] Fix crashes on ESP32-S2/S3/C3 + filter #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-around for bug in ESP-IDF < 5.0
Seems to be fixed in ESP_IDF5.1
temp_sensor_get_configalways returnsESP_OKThus
dac_offsetcan be just about anythingdac_offsetis used as index in an array without bounds checking, thus when internal I2C read to the sensor fails, you get a crash due to out-of-bound array access.I also added some filtering to make the sensor practically usable.
Old situation, 0.4 degree C resolution, no filtering:
Now with filtering:
ECO mode enabled at some point:
Guess what "task interval" is being set :)
