[WiFi] Avoid timeouts when not connected to WiFi #639
Conversation
As described in letscontrolit#381 letscontrolit#261 and letscontrolit#521 A first attempt to let all controllers use the same logic to connect to external hosts.
As discussed in letscontrolit#589 Stil needed to actively disconnect network services when network was disconnected.
All controllers now stop sending when WiFi disconnected. Also add NTP update directly after connection was made. Delay with waiting for unavailable network is now about 30 seconds, then normal boot continues. Every 60 seconds the WiFi will be polled again.
|
@psy0rz : |
|
Hi there, what's the thing with the conflict reported by Travis? |
|
I guess it is because I placed it on top of the earlier pull request #629 |
|
Ah, makes sense.
2017-12-14 15:33 GMT+01:00 Gijs Noorlander <notifications@github.com>:
… I guess it is because I placed it on top of the earlier pull request #629
<#629>
If that gets merged, the conflicts should be resolved.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#639 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZeBYhN2_pM7vZZqdQHmgcGuxmc6h1y7ks5tATGmgaJpZM4Q_vog>
.
--
Med vänliga hälsningar
Jimmy Westberg
070 65 05 709
|
|
at first glance it seems you're trying to merge some changes that also are in #629? |
|
yep the getIP() change is also in thie PR. can you untangle it? :) |
|
I've just merged the latest v2.0 changes in mega as well, so those two are in sync now. (still have a few more merges todo) |
|
@psy0rz Do I still have to "untangle" it? (e.g. merge to my 2.0 branch and create a new pull request) |
|
Yeah i dont know what went wrong exactly, but cant merge it like this. I cant tangle it as well, but since you know what you did it might be a lot easier for you. :) |
|
OK, will try to either "fix" this pull req. or create a new one. |
|
It should be mergable now. |
|
We need to test this asap and close the issue if it is resolved. |
|
thanks! |
Based on #629, so that must be merged first.
As discussed in #589
Stil needed to actively disconnect network services when network was disconnected.