fix inefficient query

postgres was doing a scan of 1M rows fml
letsdebug · Mar 15, 2022 · d8e836a · d8e836a
1 parent 3cfc2a4
commit d8e836a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/web/db.go b/web/db.go
@@ -311,7 +311,7 @@ func (s *server) listenForTests(dsn string) error {
 
 func (s *server) vacuumTests() {
 	for {
-		if _, err := s.db.Exec(`UPDATE tests set status = 'Cancelled' WHERE status NOT IN ('Cancelled','Complete') AND created_at < now() - interval '30 minutes';`); err != nil {
+		if _, err := s.db.Exec(`UPDATE tests set status = 'Cancelled' WHERE status IN ('Queued','Processing') AND created_at < now() - interval '30 minutes';`); err != nil {
 			log.Printf("Failed to vacuum: %v", err)
 		}
 		time.Sleep(10 * time.Second)

diff --git a/web/db_migrations/20180428_InitialSchema.up.sql b/web/db_migrations/20180428_InitialSchema.up.sql
@@ -1,3 +1,4 @@
+-- Warning: update server.vacuumTests() if changing this enum.
 CREATE TYPE test_status AS ENUM ('Queued', 'Processing', 'Complete', 'Cancelled');
 
 CREATE TABLE tests (