Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations does not have support for pluralization #111

Closed
bbankowski opened this issue Oct 6, 2014 · 4 comments
Closed

Translations does not have support for pluralization #111

bbankowski opened this issue Oct 6, 2014 · 4 comments
Assignees
@bbankowski
Labels
bug
Milestone
Release 1.3

Comments

@bbankowski
Copy link
Member

No description provided.

@bbankowski bbankowski added the bug label Oct 6, 2014
@bbankowski
Copy link
Member Author

My proposal is to support simple singular/plural translations:

array('key' => "I've got %{n} leg|I've got %{n} legs");

@bbankowski bbankowski self-assigned this Nov 9, 2014
@bbankowski
Copy link
Member Author

Need a review here. I added third parameter to I18n::t, which is $choice. E.g.

I18n::t('key', array('n' => 7), 7);

When it is accepted we need to add documentation.

@bbankowski bbankowski added this to the Release 1.3 milestone Nov 10, 2014
@woru
Copy link
Member

woru commented Nov 12, 2014

It could be more intuitive:

I18n::t('key', array('n' => 7), pluralizeBasedOn(7));

bbankowski added a commit that referenced this issue Nov 16, 2014
@bbankowski
Implemented pluralizeBasedOn (#111).
f1874b9
@bbankowski
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbankowski bbankowski

Labels
bug
Projects
None yet
Milestone
Release 1.3
Development

No branches or pull requests
2 participants
@woru @bbankowski