Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove regex in WillingToIssue #1442

Closed
jsha opened this issue Jan 28, 2016 · 1 comment
Closed

Remove regex in WillingToIssue #1442

jsha opened this issue Jan 28, 2016 · 1 comment

Comments

@jsha
Copy link
Contributor

jsha commented Jan 28, 2016

We have a regex for valid DNS labels in WillingToIssue, but it mostly overlaps the other checks in that function. We should pull it out for clarity. We need to implement at least two things that it checks: characters are all lower case; label doesn't start with a hyphen (label doesn't end with a hyphen is done in #1440).
@jsha
Copy link
Contributor Author

jsha commented Jun 4, 2016

Won't fix.

@jsha jsha closed this as completed Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdaehlie @jsha