Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable wastedassign lint #6202

Open
jsha opened this issue Jun 29, 2022 · 2 comments
Open

Re-enable wastedassign lint #6202

jsha opened this issue Jun 29, 2022 · 2 comments

Comments

@jsha
Copy link
Contributor

jsha commented Jun 29, 2022

Right now, the wastedassign lint in golangci-lint gives this error:

WARN [linters context] wastedassign is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.

We should disable it for now to be clear we are not getting its benefit, and re-enable it once golangci-lint fixes it for use under go1.18.

@aarongable
Copy link
Contributor

(Update: wastedassign still does not support generics. You can track golangci-lint's progress on fixing various sub-linters here: golangci/golangci-lint#2649)

@aarongable
Copy link
Contributor

According to this bug, wastedassign now works with generics. But when I re-enable it in our golangci.yml, it prints the message "WARN [linters_context] wastedassign is disabled because of generics.". So I guess we're still waiting on a new release of golangci-lint to enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants