Add CFSSL integration and move storage to SQL #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (ra *RegistrationAuthorityImpl) NewAuthorization(request Authorization, key jose.JsonWebKey) (Authorization, error) { | ||
| zero := Authorization{} | ||
| func lastPathSegment(url AcmeURL) string { | ||
| return regexp.MustCompile("^.*/").ReplaceAllString(url.Path, "") |
There was a problem hiding this comment.
Should really save the result of MustCompile someplace for reuse, instead of recompiling it each time.
bifurcation
added a commit
that referenced
this pull request
Mar 6, 2015
Add CFSSL integration and move storage to SQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP. There needs to be some further evolution in the storage story before this is ready to land.