Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publisher tests to use new realistic test certs #5280

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

beautifulentropy
Copy link
Member

A new, more realistic, test certificate hierarchy was added in #5273.

Update publisher tests to use the test certificate hierarchy now present
at test/hierarchy.

Fixes #5279

A new, more realistic, test certificate hierarchy was added in #5273.

Update publisher tests to use the test certificate hierarchy now present
at test/hierarchy.

Fixes #5279
@beautifulentropy beautifulentropy requested a review from a team as a code owner February 10, 2021 23:33
aarongable
aarongable previously approved these changes Feb 10, 2021
Copy link
Member

@andygabby andygabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on a comment that needs update, but otherwise looks good!

publisher/publisher_test.go Outdated Show resolved Hide resolved
Co-authored-by: Andrew Gabbitas <agabbitas@letsencrypt.org>
@beautifulentropy beautifulentropy merged commit f13b8db into main Feb 11, 2021
@beautifulentropy beautifulentropy deleted the publisher-realistic-test-chains branch February 11, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update publisher tests to use new realistic test certs
3 participants