Fix typos

[szepeviktor]

Found new misspellings.

typos is a better tool than the current spell checker.

[szepeviktor]

For anyone interested in .typos.toml

[files]
extend-exclude = [
    ".git/",
    ".codespell.ignore.txt",
    "go.mod",
    "go.sum",
    "vendor/",
]
ignore-hidden = false

[default]
extend-ignore-re = [
    # PEM
    "\\b[+/0-9=A-Za-z]{64}\\b",
    ' := `\{"[0-9A-Z_a-z-]{36,}"\}`',
    '"(csr|d|dp|n|protected|qi|signature|y)": ?"[0-9=A-Z_a-z-]{36,}"',
    'bigIntFromB64\("[0-9=A-Z_a-z-]{36,}"\)',
    "0002a4ba3cf408927759",
    "65CuDAA",
    '"sql_warnings", "TrUe"',
    '"tx_read_only", "FalSe"',
    "evenMOREcaps",
    '"iSsUe"',
]

[default.extend-words]
# Extended DNS Error
"ede" = "ede"
# Alternative spelling
"unmarshaling" = "unmarshaling"

[default.extend-identifiers]
"caaFailer" = "caaFailer"
"challStrat" = "challStrat"
"ExpectedStratType" = "ExpectedStratType"
"otConf" = "otConf"
"serInt" = "serInt"
"StratName" = "StratName"
"UPDATEs" = "UPDATEs"
"vai" = "vai"

[pgporada]

Thanks! We currently use misspell via .golangci.yml and codespell. Would you like to file an additional PR to implement typos?

[szepeviktor]

You're welcome.

I could replace codespell with typos.
Is it okay for you?

[szepeviktor]

But typos is a single Go binary, not a Python package

boulder/test/boulder-tools/requirements.txt

Line 5 in c1f7de0

codespell==2.2.5

[pgporada]

That seems alright, let's give it a shot.

[szepeviktor]

Sorry. I was wrong.
typos is written in Rust.
https://github.com/crate-ci/typos

I know how to download it locally, and how to use it in GitHub Actions.
uses: crate-ci/typos@v1.17.0

[aarongable]

Thanks for catching these typos! As far as I can tell, the rust "typos" crate behaves very differently from codespell -- rather than having a dictionary of known words and triggering on anything it doesn't recognize, it has a dictionary of known typos and triggers on seeing those. So it has low false positives, but potentially high false negatives. I'd be happy to accept a PR which runs it alongside codespell; I think we'd want to talk a bit more about using it to wholly replace codespell.

[aarongable]

@szepeviktor We discussed this today, and we'd be happy to replace codespell with typos! Removing python from our toolchain is good. I'm going to merge this change now so we get these benefits immediately, but if you'd like to prepare another PR that removes codespell and replaces it with pre-built typos binaries (we will need a binary for arm64, too) then we'd love to accept that contribution too. Thanks!

[szepeviktor]

All right.
Is test.sh the only place I have to operate?

boulder/test.sh

Line 222 in 5c0ca04

run_and_expect_silence codespell \

[aarongable]

No, the only reason test.sh is able to directly call codespell like that is because test.sh runs inside our testing docker container, which installs codespell as part of the container creation process. You'll want to remove that, and probably want to add steps that install typos to the same container image inside build.sh or in the dockerfile directly.