Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Remove note about not supporting EAB. #328

Merged
merged 1 commit into from Oct 9, 2020

Conversation

cpu
Copy link
Contributor

@cpu cpu commented Oct 8, 2020

Since #288 Pebble does support external account binding (EAB). This commit updates the "Limitations" section of the README accordingly.

Since letsencrypt#288 Pebble **does** support external account binding (EAB). This commit updates the "Limitations" section of the README accordingly.
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@cpu
Copy link
Contributor Author

cpu commented Oct 9, 2020

@jsha Could you merge this when you have a chance? Ty!

@felixfontein
Copy link
Contributor

@cpu good to see you're still around :)

@cpu
Copy link
Contributor Author

cpu commented Oct 9, 2020

@felixfontein Regretfully just for drive-by README updates and not anything more interesting! 😆

@jsha jsha merged commit a1a52e8 into letsencrypt:master Oct 9, 2020
@jsha
Copy link
Contributor

jsha commented Oct 9, 2020

Thanks for the reminder! I was waiting for CI, and forgot to circle back around 🤦🏻

@cpu cpu deleted the patch-1 branch October 9, 2020 18:30
Copy link

@AlphaMale1st AlphaMale1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies my children, 4give me. Wipe the sleep out, wake up theres fresh aroma brewing all around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants