Remove KeyAuthorization from challenge updates.
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per ACME draft-10 challenge update POST bodies should no longer include the `KeyAuthorization` field, the server can calculate this on its own. Similarly, it shouldn't be returned in challenge bodies sent to the client because the client can calculate it themselves. This commit updates Pebble to *reject* challenge updates with a `KeyAuthorization` field. This is fairly aggressive: We could simply ignore this field, but Pebble is meant to encourage good client behaviour so we'll be more aggressive than Boulder will.
|
This breaks in CI because Chisel2 sends the legacy field: Fixing that is likely blocked on letsencrypt/boulder#3514 in Boulder. |
jsha
reviewed
Mar 6, 2018
wfe/wfe.go
Outdated
| // sent (and that's what Boulder will do) but for Pebble we'd like to be more | ||
| // aggressive about pushing clients implementations in the right direction, so | ||
| // we treat this as a malformed request. | ||
| if chalResp.KeyAuthorization != "" { |
There was a problem hiding this comment.
Let's make this field a pointer so we can check if it's present at all. Otherwise we'll accept its presence with an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per ACME draft-10 challenge update POST bodies should no longer include
the
KeyAuthorizationfield, the server can calculate this on its own.Similarly, it shouldn't be returned in challenge bodies sent to the
client because the client can calculate it themselves.
This commit updates Pebble to reject challenge updates with
a
KeyAuthorizationfield. This is fairly aggressive: We could simplyignore this field, but Pebble is meant to encourage good client
behaviour so we'll be more aggressive than Boulder will.