Metrics for TLS resumes, DoH, and aggressive NSEC #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch maps unbound's `num.query.agressive.*` stats to `query_aggressive_nsec` metrics. This counter tracks the number of queries that unbound synthesised answers based on the cached NSEC records. See <https://unbound.docs.nlnetlabs.nl/en/latest/topics/privacy/aggressive-nsec.html> Closes: letsencrypt#48
This patch adds `query_tls_resume_total` and `query_https_total` metrics, which track the number of queries received using TLS resume and DNS-over-HTTPS transport, resp. Also the descriptions for `query_tcp_total` and `query_tls_total` are clarified that these numbers include DoT and DoH queries.
|
👍 to this PR. Looking forward to query_https_total metrics to appear in next release. Unfortunately this PR didn't make it to 0.4.2 |
|
I'm taking a look at this now. |
pgporada
reviewed
Aug 21, 2023
pgporada
approved these changes
Aug 21, 2023
pgporada
requested review from
a team and
aarongable
and removed request for
a team
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=====================================
Coverage 5.23% 5.23%
=====================================
Files 1 1
Lines 191 191
=====================================
Hits 10 10
Misses 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
aarongable
approved these changes
Aug 23, 2023
|
Thank you both for your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggressive NSEC stats
This patch maps unbound's
num.query.agressive.*stats toquery_aggressive_nsecmetrics.This counter tracks the number of queries that unbound synthesised answers based on the cached NSEC records.
See https://unbound.docs.nlnetlabs.nl/en/latest/topics/privacy/aggressive-nsec.html
Closes: #48
More transport stats: TLS resumes and DoH queries
This patch adds
query_tls_resume_totalandquery_https_totalmetrics, which track the number of queries received using TLS resume and DNS-over-HTTPS transport, resp.Also the descriptions for
query_tcp_totalandquery_tls_totalare clarified that these numbers include DoT and DoH queries.