Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track memory used by DoH buffers #72

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Track memory used by DoH buffers #72

merged 3 commits into from
Jan 30, 2024

Conversation

pgporada
Copy link
Member

Fixes #71

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e284f50) 5.23% compared to head (677514f) 5.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #72   +/-   ##
=====================================
  Coverage   5.23%   5.23%           
=====================================
  Files          1       1           
  Lines        191     191           
=====================================
  Hits          10      10           
  Misses       181     181           
Flag Coverage Δ
unbound_exporter_tests 5.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcpherrinm
Copy link
Contributor

want to add this to the expected metrics list in the integration test? https://github.com/letsencrypt/unbound_exporter/blob/main/integration_test.go#L47

@pgporada pgporada requested review from jprenken, a team and jsha and removed request for a team January 29, 2024 21:35
@pgporada pgporada merged commit ab17c00 into main Jan 30, 2024
5 checks passed
@pgporada pgporada deleted the doh-metrics branch January 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrape DOH metrics: mem.http.query_buffer and mem.http.response_buffer
5 participants