Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsor and Donor logos clash with body background-color #256

Closed
jonathansampson opened this issue Feb 27, 2018 · 5 comments · Fixed by #607
Closed

Sponsor and Donor logos clash with body background-color #256

jonathansampson opened this issue Feb 27, 2018 · 5 comments · Fixed by #607

Comments

@jonathansampson
Copy link

Sponsor and Donor logos have a white background, which clashes with the #fdfdfd body background. The following GIF shows the Sponsor/Donor region with and without the default background color:

lets-encrypt

@tdelmas
Copy link
Collaborator

tdelmas commented Jun 30, 2019

I confirm I see that problem. Maybe the background of the div containing all the logo could be set to white ? (I had to look at my screen from an odd angle to see the animation of your gif...)

@tdelmas
Copy link
Collaborator

tdelmas commented Aug 17, 2019

To make the problem more visible I changed the background:

image

One possible fix could be to force white background for these images. It will still clash with the body background on some screens, but at least it will be consistent (and simpler than requesting new images with transparent background)

@bdaehlie
Copy link
Contributor

Here's the history of the inconsistency...

Each sponsor image comes in two sizes, big and small. Small is used for the main page of the website. We used to use transparent backgrounds for both sizes, but at some point we switched to white backgrounds for the smaller images to make their size smaller.

I'm not sure what the best path forward is since it's a lot of work to make these from the original source files, making sure the clipping and dimensions are correct and the resizing looks good.

@tdelmas
Copy link
Collaborator

tdelmas commented Aug 17, 2019

So I think the short-term fix of a simple CSS rule to force white background for these image is the good path forward, so, in case we change our mind, it'll be easier.

img.donor {
  background-color: #ffffff;
}

@bdaehlie
Copy link
Contributor

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants