fix(email): Change as_ref() to as_str() to fix nightly bug #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to build
lettre
with the latest nightly (2019-05-18), you get the error illustrated below. This is probably not a bug inlettre
but rather a bug in the latest Rust nightly. That said, changing all theas_ref
calls toas_str
calls inlettre_email/src/lib.rs
(as this PR does) fixes the issue without really changing the intent of thelettre
code.Not sure this is worth incorporating, as, again, I suspect the problem is really with Rust nightly, not
lettre
. That being said, this little fix (changing toas_str
) ensureslettre
continues to work on nighty as of right now.