-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transport): add sendmail transport #83
Conversation
There were the following issues with your Pull Request
Guidelines are available at https://github.com/lettre/lettre/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need a section in the usage doc in lib.rs
for this new transport.
This is a nice improvement, thanks!
pub mod error; | ||
|
||
/// Writes the content and the envelope information to a file | ||
pub struct SendmailTransport; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make the command to use configurable, and store it in SendmailTransport
.
|
||
impl EmailTransport<SendmailResult> for SendmailTransport { | ||
fn send<T: SendableEmail>(&mut self, email: T) -> SendmailResult { | ||
// Spawn the `wc` command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should be removed.
Addresses: Sendmail transport support #40