feat(transport): add sendmail transport #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/lettre/lettre/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
amousset
changed the title
amousset
requested changes
Oct 22, 2016
| pub mod error; | ||
|
|
||
| /// Writes the content and the envelope information to a file | ||
| pub struct SendmailTransport; |
There was a problem hiding this comment.
I think we need to make the command to use configurable, and store it in SendmailTransport.
|
|
||
| impl EmailTransport<SendmailResult> for SendmailTransport { | ||
| fn send<T: SendableEmail>(&mut self, email: T) -> SendmailResult { | ||
| // Spawn the `wc` command |
There was a problem hiding this comment.
This comment should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: Sendmail transport support #40