Master #1
Merged
Master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The credentials should be deleted after the session has been closed with pam_close_session.
We now handle correctly the following situations: - Empty theme in the settings: fallback to the embedded theme. - Selected theme doesn't exist: load the first one in alphabetical order like before, in addition to that fallback to the embedded theme if there are no themes at all. - Selected theme has QML errors: fallback to the embedded theme and display the errors prompting the user to select another one. This means that in any case we always let the user log in with a theme embedded into the executable in order to be sure it always exist. Closes: #551 Closes: #632
Just reload the configuration.
Scaled from an SVG created exclusively for the purpose. Signed-off-by: Sanjeev Premi <spremi@ymail.com>
Using the first alphabetical theme is confusing because it is just random for the user, fallback to the embedded theme instead.
QFile::exists("...") does not understand file:// URLs, at least in Qt
5.7.0 and Qt 4.8.7.
Remove quotes from ServerArguments since it goes directly in the command line:
Running: /usr/bin/X "-nolisten tcp -dpi 192" -auth /var/run/sddm/{...} -background none -noreset -displayfd 21 vt1
The new EnableHiDPI boolean option permits to enable or not the activation of Qt::AA_EnableHighDpiScaling attribute. The default is enabled. [ChangeLog][Greeter] Enable Qt's automatic high dpi scaling based on configuration Signed-off-by: Stany MARCEL <stanypub@gmail.com>
The X root window uses an "X" as the default cursor. To use a themed one, it has to be set explicitly, e.g. by QML MouseAreas. For themes which do not have a MouseArea that spans the entire screen, the "X" cursor would be visible. By setting a cursor in the root QML object, the themed cursor will be used by default. (https://bugs.kde.org/show_bug.cgi?id=337083) [ChangeLog][Greeter] Fix default cursor appearance
[ChangeLog][Themes] Update date and time in the "elarun" theme Closes: #665
[ChangeLog][Translations] Add Hindi Signed-off-by: Sanjeev Premi <spremi@ymail.com>
[ChangeLog][Translations] Complete Swedish Signed-off-by: Kristoffer Grundström <hamnisdude@gmail.com>
By default, QSettings doesn't support non-lating characters in config file. However, KCM will write background path into theme config file without escape. That means, we need to read UTF-8 strings. [ChangeLog][Themes] Support UTF-8 in theme configuration
A better translation for the term "Layout" which corresponds in this context to "keyboard". Le "Layout" dans ce contexte correspond à la disposition du clavier. Ce terme me semble plus parlant que "Configuration" qui est très général. [ChangeLog][Translations] Improved French translation
to get the fish-specific login environment instead of the catchall /etc/profile environment.
Gnome's keyring stores user keys (eg: wifi passwords) encrypted, and uses a pam module to unlock them at login. This patch adds `optional` support for the gnome_keyring pam module, so Gnome can be launched successfully from SDDM. Without this, Gnome will ask for the users password again after logging in, the first time it needs to access the keyring, in order to unlock it. Other display managers as the Gnome Display Manger [1], LightDM [2] and Enlightment's Entrance [3] already do this. [1] https://github.com/GNOME/gdm/blob/master/data/pam-arch/gdm-password.pam [2] http://bazaar.launchpad.net/~lightdm-team/lightdm/trunk/view/head:/debian/lightdm.pam [3] https://git.enlightenment.org/misc/entrance.git/tree/data/entrance [ChangeLog][Pam] Unlock GNOME keyring on login
Add kwallet-pam support for the plasma5 desktop
Note: It is only working with an empty kwallet password.
Instead of using naive approach of trying to detect duplicates when inserting a new user into the list of users, which is O(n^2) complexity, let's filter them out after the fact, which is much more efficient on real-world data. With this change time to load user list in our environment (over 500000 account entries) is reduced from over 1 hour to about 2 seconds.
std::unique() is "interesting": it modifies the container, rearranging elements in it, but does not reduce the size of the container, so there are invalid elements at the end that have to be erased explicitly.
sddm.conf overrides the configuration from the conf.d directories and we don't want that. SDDM still reads it if users keep the file after an upgrade, but since the introduction of conf.d directories we shouldn't install sddm.conf by default. [ChangeLog][Daemon] Do not install /etc/sddm.conf anymore
QLatin1String only got more QString-like with Qt 5.10, so we can't use those methods.
Add Icelandic translation file. [ChangeLog][Translations] Add Icelandic
Instead of checking for existence of theme-specific icon and re-creating string literals every time we add a new user to the list, do it once. It helps in large organizations with a lot of users.
Signed-off-by: now-im <now.im.627@gmail.com>
- fix loading default theme if none is set
When compiled with USE_PAM, prefer a combination of getgroups(3) and getgrouplist(3) for ambient and user groups, respectively, to initgroups(3). This way, groups injected into the PAM environment by means of pam_groups.so aren't ignored. Signed-off-by: J. Konrad Tegtmeier-Rottach <jktr@0x16.de>
Skip theme for greeter call if none is set
X server may break down without writing a display number
to the pipe specified by '-displayfd'. SDDM should exit explictly
in such cases. Otherwise, it will get a null string for display number,
which leads /usr/bin/xauth gets bad parameters, i.e.
/usr/bin/xauth: (stdin):1: bad "remove" command line
/usr/bin/xauth: (stdin):2: bad "add" command line
qt5_use_modules was deprecated for quite some time and got finally removed.
Same treatment as for Hidden. SessionModel is not used for autologin, so for all intents and purposes it's the same. If a user logged in with a NoDisplay=true session, the last session index will be incorrect, but IMO that's the intended behaviour of NoDisplay.
SDDM did not compile on musl libc, since HelperApp.cpp was using gettimeofday(), which is defined in <sys/time.h>, without importing it. [ChangeLog][Helper] Fix build with musl libc.
translated hibernate and suspend add enter your password/ username for to use with tooltips
add translation for hibernate and suspend add translation toenter username/ password for to use with tooltips
- Check the success value before unlocking the session - Don't attempt to use the nonexistant "sddm-check" PAM service
Fix authentication when reusing an existing session
This ensures the right paths are set by upstream apps that use the /etc/profile(.d) method for setting paths, for example xdg or snap. Signed-off-by: James Turnbull <james@lovedthanlost.net> [ChangeLog][Xsession] Source /etc/profile for fish too Closes: #879
Seats can't be created until SeatManager's signals are connected to the DisplayManager, or the latter won't see them and switchToGreeter doesn't work. So split SeatManager initialization from its constructor and call initialize it only after all connections have been set up in DaemonApp's constructor. With logind there may have been enough delay before seats got actually added so things would work, but it's still cleaner to fix the order. Fixes: https://bugs.gentoo.org/644718 Fixes: #824
This connect was done for all views so previously when any screen was removed all views would be.
m_auth is connected to ::authentication in the constructor so use of a second connect is really weird and runs in an undetermined order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.