Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog and upgrade guide for v5.0.0-rc1 #548

Merged
merged 11 commits into from
Dec 16, 2018
Merged

Changelog and upgrade guide for v5.0.0-rc1 #548

merged 11 commits into from
Dec 16, 2018

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Dec 15, 2018 •
edited

Done up to and including the N-API rewrite.

Closes #512.

@vweevers vweevers added the documentation Improvements or additions to documentation label Dec 15, 2018
@vweevers vweevers added this to Backlog in Level (old board) via automation Dec 15, 2018
@vweevers vweevers moved this from Backlog to In progress in Level (old board) Dec 15, 2018
@targos targos mentioned this pull request Dec 15, 2018
Closed
ralphtheninja
ralphtheninja approved these changes Dec 15, 2018
View reviewed changes
Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vweevers vweevers changed the title Changelog for v5.0.0-rc1 [WIP] Changelog and upgrade guide for v5.0.0-rc1 [WIP] Dec 15, 2018
@vweevers
Copy link
Member Author

vweevers commented Dec 15, 2018 •
edited

Let's keep this open until the few remaining tasks are done.

Yet to add:

  • changelog: prebuildify
  • changelog: minimum node version
  • upgrade guide: the sync option has moved to chainedBatch.write(options). Previously, sync was half-documented and half-implemented.

vweevers
vweevers commented Dec 16, 2018
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
@ralphtheninja
Copy link
Member

@vweevers Time to get this merged? I want to release rc1 :)

@vweevers vweevers changed the title Changelog and upgrade guide for v5.0.0-rc1 [WIP] Changelog and upgrade guide for v5.0.0-rc1 Dec 16, 2018
@vweevers
Copy link
Member Author

vweevers commented Dec 16, 2018 •
edited

Will rebase after review of the last 4 commits why

@vweevers vweevers merged commit 0c4b978 into master Dec 16, 2018
Level (old board) automation moved this from In progress to Done Dec 16, 2018
@vweevers vweevers deleted the changelog/v5.0.0-rc1 branch December 16, 2018 20:07
@vweevers vweevers mentioned this pull request Dec 16, 2018
Closed
@rvagg rvagg mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vweevers @ralphtheninja