-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecosystem Modules that will break in Node 12 #25060
Comments
@mcollina Sorry I missed your issue. I also prefer to have a table layout. I added a column with checkboxes. |
I’m ok of closing my issue but changing the title of this one. |
I added sqlite3, leveldown, level and iconv to the list. Someone should open an issue for the first 3. |
leveldown is fixed in the upcoming v5 release cc @ralphtheninja. |
Filed mishoo/UglifyJS#3304 for Not a big issue overall, they are basically testing the |
serialport should be fixed in master, lmk |
@silverwind Might want to see if this affects terser. |
Quite some of the fails are because of NAN which is not yet prepared for Node 12 but V8 API has changed since Node 10/11. |
According to the Chromium release calendar, I think we will aim for V8 7.4 in Node 12, maybe with a forward-compat patch to have the API of V8 7.5. |
As far as I know, V8 does not plan to remove any of the non-deprecated methods in non-major releases. Is this assumption correct? cc @nodejs/v8. I think the plan should be to just remove all usage of currently deprecated methods in V8 in master. |
@mcollina that's correct, but what they often do is deprecate in a version (e.g. 7.3) and remove in the next (7.4). |
I created nodejs/nan#831 I think this is a better place to discuss this in detail. |
V8 removes APIs by first marking them V8_DEPRECATED, and waits at least one version bump (e.g. 7.3 to 7.4) before actually removing it. That said, we take precautions for the time around Node.js LTS releases to not unnecessarily break ABI stability. |
I created a roadmap for V8 in Node.js 12 here. |
PR fix for |
we might also want to call this out in the change log |
Fixed |
Sqlite and node-gyp fixes also merged, no? |
Merged but not shipped yet. |
Should this be added here? facebook/create-react-app#6891 |
node-java v0.11.0 seems also not to be working with node v12.0.0 |
bignum isn't working with 12 and it's causing some angst. justmoon/node-bignum#120 It could really do with a conversion to node-addon-api but the distance between nan and addon-api for object wrapped addons with lots of constructor work is a bit too much of a stretch for me with the limited mental bandwidth I can afford for it. I have publish rights if someone wants to do the work though! |
I fixed the test failure with the bignum PR porting o 12.x, but don't have time ATM for a rewrite. |
weak-napi (alternative to weak) is also broken. I have attempted to fix it but it's segfaulting sometimes for a reason that's beyond me. |
The weak-napi test suite passes for me (Node.js 12.4.0):
Do you have a reproducible test case that segfaults? |
@targos Heres the corresponding issue node-ffi-napi/weak-napi#16 I've got to the point that the test cases pass (using nodejs/node-addon-api#475), but real world stressing code triggers segfaults. I'm on 12.3.x I'll upgrade my test to 12.4.0 and re-confirm with vanilla napi and patched. |
I can confirm the issue exists with 12.4.0 both with vanilla napi and patched. |
node-nanomsg broken in v12: nickdesaulniers/node-nanomsg#206 |
Hi, https://travis-ci.org/isaacs/node-graceful-fs/jobs/550978466 |
Not sure if https://github.com/TooTallNate is active on the |
Do we need to keep this open? Node 12 is released and I understand this issue was to track issues before release. Posting Node 12 issues here will not magically fix them. |
The head version of But not released yet… |
@silverwind You're right, let's close this. |
This is an issue meant to track modules that are currently skipped in citgm because they (or their tests) are currently broken on current versions of Node.
Feel free to edit this post to update the table.
The text was updated successfully, but these errors were encountered: