Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom formatting of date/time columns in CSV export #106

Merged
merged 1 commit into from
May 14, 2020

Conversation

bladams
Copy link
Contributor

@bladams bladams commented May 13, 2020

Fixes #98

@bladams bladams requested a review from a team May 13, 2020 19:25
@bladams bladams self-assigned this May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #106 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   87.48%   87.53%   +0.04%     
==========================================
  Files          17       17              
  Lines        4804     4821      +17     
  Branches      369      370       +1     
==========================================
+ Hits         4203     4220      +17     
  Misses        544      544              
  Partials       57       57              
Impacted Files Coverage Δ
webgrid/tests/test_rendering.py 99.85% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf13a3e...514cef6. Read the comment docs.

@guruofgentoo guruofgentoo merged commit 1fb7d03 into master May 14, 2020
@guruofgentoo guruofgentoo deleted the 98-date-csv-formatting branch May 14, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateColumn.render_csv return type
2 participants