New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use level 8 #199
Conversation
Adds a levelup.createValueStream polyfill, as that's no longer in level 8
FYI for the streams, see https://github.com/Level/read-stream |
Awesome, I'll try to implement that tomorrow instead of the custom workaround |
Just tried using level-read-stream, but I ran into the following error:
With method being I'll certainly have to fix this some time, but for now I'd say that's out of scope for this PR, as the workaround supports both the older and newer interface. |
Was that when using |
Correct, that was using level-mem. Using level@8 that could simply be replaced by |
I assume that the tests here use If so then replace: const mem = require('level-mem')
const db = mem() With: const { MemoryLevel } = require('memory-level')
const db = new MemoryLevel() |
Gotcha, will test locally and commit if that'll work including |
@mcollina Still in doubt on the changelog that scenaristaur added, as it's current state doesn't really make sense to me. Would the current state of this PR be fine by you code-wise? If so, I'll start on updating the readme to match the current state, and the version bump would probably have to be a major as it's breaking changes for people on older versions of leveldb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing Work!
Can you update CI to support only Node v18 an v20? I'll bump a major anyway. |
Sure, I'll make it run 18/20 |
… with markdown again
One more issue I have with the contributor table: it seems jez0990 has removed their github profile. Should we hunt for their current online presence or just leave it as-is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Includes:
Extras: