Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email privacy #289

Closed
Laiagdla opened this issue Apr 17, 2024 · 4 comments · Fixed by #295
Closed

email privacy #289

Laiagdla opened this issue Apr 17, 2024 · 4 comments · Fixed by #295

Comments

@Laiagdla
Copy link

Laiagdla commented Apr 17, 2024

Hi! regarding the part of signing in to github and dotfiles.
I just discovered that the name and email, specified in the "gitconfig" is being used to sign commits, even in public repos.
Would it be considered a useful warning for people to know that the full name and this email might be shown publicly at some point? if they create or contribute to a public repo, for example.

or also implement this posibility?
https://stackoverflow.com/questions/7372970/git-commit-with-no-email/71542189#71542189

When contributing to github, always use the anonymous noreply email address provided by github - which you can find here: https://github.com/settings/emails (have to tick "Keep my email addresses private" to see it).

gitconfig looking like this:

[user]
    name = Joe Blogs
    email = ID+username@users.noreply.github.com
@julesvanrie
Copy link
Contributor

Thanks for reporting.

Created a new issue in teachers so I can discuss with WebDev and Data Engineering track owners because this part is common to all three setups.

@ssaunier
Copy link
Member

Fixed by lewagon/setup#467

@julesvanrie
Copy link
Contributor

This was still to do for DS, but I just did it.

This notice is in the dotfiles part and that is a separate partial for DS <> web (catering for case where the student did web bootcamp before).

@ssaunier
Copy link
Member

Sorry I forgot about the other repo, thanks for getting on it so quick! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants