Add note about email privacy with GitHub #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eschults
approved these changes
May 2, 2024
_partials/dotfiles.md
Outdated
| @@ -67,7 +67,8 @@ cd ~/code/$GITHUB_USERNAME/dotfiles && zsh git_setup.sh | |||
|
|
|||
| :point_up: This will **prompt** you for your name (`FirstName LastName`) and your email. | |||
|
|
|||
| :warning: You **need** to put one of the email listed above thanks to the previous `gh api ...` command. If you don't do that, Kitt won't be able to track your progress. | |||
| :warning: You **need** to put one of the emails listed above thanks to the previous `gh api ...` command. If you don't do that, Kitt won't be able to track your progress. Whichever email you pick will be shown **publicly** on the internet. GitHub automatically generates an address for you like `123098213+USERNAME@users.noreply.github.com`, so you should choose this email if you do not want your real email address to be public. | |||
There was a problem hiding this comment.
❓ should we make it shorter, something along:
💡 Select the
@users.noreply.github.comaddress if you don't want your email to appear in public repositories you may contribute to.
There was a problem hiding this comment.
Oh that's better haha
|
@Eschults thank you for that! Implemented |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve https://github.com/lewagon/teachers/issues/2512
I don't .... .... think this should cause any issues!