Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDOWS: fix warning "bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8) #459

Closed
v-natalia opened this issue Mar 12, 2024 · 6 comments · Fixed by #461
Closed

Comments

@v-natalia
Copy link

v-natalia commented Mar 12, 2024

Hi,
Many students get this warning after running the commands of the section locale:

bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)

I've seen this in students with laptops configured to use other languages different than english, and so they get this warning even after generating the locale.
I propose to add the following paragraph to the section locale


If after, you receive a warning ("bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)) in your terminal, please do the following:

<details>
  <summary>Generate locale</summary>
Please, run this lines in your terminal.
```bash
sudo update-locale LANG=en_US.UTF8
sudo apt-get install language-pack-en language-pack-en-base manpages
exec zsh
```
@v-natalia
Copy link
Author

cc @xeonnux

@xeonnux
Copy link

xeonnux commented Mar 12, 2024

I confirm this is very common during the setup days. I would also recommend moving the locale section in the setup to right after the dotfiles section since this is usually around there that the issue pops up and would be more effective.

Also the student should definitely run

exec zsh

right after running the above mentioned commands from @v-natalia to see it effective.

(c/c @ajdubovoy )

@v-natalia
Copy link
Author

I just added this line, thanks @xeonnux

@ajdubovoy
Copy link
Contributor

Hi! I'm adding this right now. @xeonnux I'm not sure what you mean about the order though? The locale section is before the dotfiles already

ajdubovoy added a commit that referenced this issue Mar 14, 2024
@xeonnux
Copy link

xeonnux commented Mar 15, 2024

@ajdubovoy what I mean is locale should be removed from the ubuntu section and moved to this section here https://github.com/lewagon/setup/blob/master/windows.md#git-installer

@ajdubovoy
Copy link
Contributor

Oh, understood. Is there any advantage to moving it down if we're already making sure it works properly further up?

Eschults pushed a commit that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants