Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem installs - Better explanation + CHECK #374

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Gem installs - Better explanation + CHECK #374

merged 4 commits into from
Apr 6, 2022

Conversation

ssaunier
Copy link
Member

@ssaunier ssaunier commented Apr 6, 2022

Fixes #372

This proposition has three sections:

  • Better phrasing of the Markdown around the gem install ... to encourage everyone to run that command
  • Checking the required gems are actually installed in the check.rb at the end of the setup (with a special case for Rails)
  • Introduces GEMS in the build.rb to have a single source of truth for all .md files. Note that bundler is installed with Ruby since 2.6 (so removed), pry-byebug has a dependency on pry (so removed), and same for rubocop-performance / rubocop.

@ssaunier ssaunier requested a review from dmilon April 6, 2022 14:35
Copy link
Contributor

@dmilon dmilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🙏

@dmilon dmilon merged commit 54cf3cf into master Apr 6, 2022
@dmilon dmilon deleted the gem-installs branch April 6, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent skipping in gems installation
2 participants