Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Le Wagon Setup now in Portuguese version too #442

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

carlosferrerdev
Copy link
Contributor

Good afternoon, Le Wagon.

I created a Portuguese version of Le Wagon Setup to help the entire Le Wagon global community who speak Portuguese as their native language.

I'm making this pull request to check if everything is in order to merge and help the community. :)

@olivergiles
Copy link
Contributor

Hi @carlosferrerdev, thanks for this I don't see any problem adding an extra language but it needs to split into partials! If you see in this folder https://github.com/lewagon/setup/tree/master/_partials there is a .md per section and then folders for the alternative languages. So a pt folder needs to created and populated and then pt it needs to be added to this line https://github.com/lewagon/setup/blob/master/build.rb#L97C1-L98C40!

@carlosferrerdev
Copy link
Contributor Author

carlosferrerdev commented Sep 19, 2023

Hi @carlosferrerdev, thanks for this I don't see any problem adding an extra language but it needs to split into partials! If you see in this folder https://github.com/lewagon/setup/tree/master/_partials there is a .md per section and then folders for the alternative languages. So a pt folder needs to created and populated and then pt it needs to be added to this line https://github.com/lewagon/setup/blob/master/build.rb#L97C1-L98C40!

Hi, @ogiles1999. Thanks for this comment. I will do the mencioned changes.

@carlosferrerdev
Copy link
Contributor Author

Hey @ogiles1999,
Can you check the changes I've made? Thanks :)

Copy link
Contributor

@olivergiles olivergiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @carlosferrerdev

@olivergiles olivergiles merged commit efc07c3 into lewagon:master Sep 20, 2023
@olivergiles
Copy link
Contributor

If you want to check the output looks all good it looks like it has generated correctly https://github.com/lewagon/setup/blob/master/README.pt.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants