Add support for building under Clang and Linux #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip building file I/O files as these are currently Windows only.
Fixed missing include.
The promise_type::get_return_object() method was returning a reference to the promise object, expecting that reference to be passed to the constructor of recursive_generator<T>. However, under Clang the result of get_return_object() is assigned to an 'auto' variable, which ends up taking a copy of the promise object on the stack and passing that copy into the recursive_generator<T> constructor. Modified get_return_object() to return the already-constructed recursive_generator<T> object.
debug: -O0 -g optimised: -O2 -g -flto
# Conflicts: # tools/cake
- Disable the test that requires io_service when not on Windows. - Add missing #include.
It now supports being built with clang 6.0.
This bug has been fixed in clang-6.0.
# Conflicts: # test/build.cake
Cast result to (void) where we are intentionally ignoring the return value.
|
Closes #3. |
Garcia6l20
pushed a commit
to Garcia6l20/cppcoro
that referenced
this pull request
Jan 5, 2021
Add clang-12 to CI configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.caketo define build variants for Linux+Clang x64 optimised/debug.-O0-O2 -lto