Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove possible warnings with redefinitions #71

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

Uran198
Copy link
Contributor

@Uran198 Uran198 commented Mar 9, 2018

If the library is used as part of a bigger project some definitions can
be provided via external build files.

If the library is used as part of a bigger project some definitions can
be provided via external build files.
@lewissbaker
Copy link
Owner

So the issue you're trying to solve here is that you're already defining WIN32_LEAN_AND_MEAN on the command-line in your build system which is compiling cppcoro sources directly rather than using the output of the cake build system?

There are a couple of new files in the sockets2 branch that may require compilation without WIN32_LEAN_AND_MEAN defined. I'll try out this change with those branches but otherwise it seems like a reasonable change to me.

@Uran198
Copy link
Contributor Author

Uran198 commented Mar 13, 2018

So the issue you're trying to solve here is that you're already defining WIN32_LEAN_AND_MEAN on the command-line in your build system which is compiling cppcoro sources directly rather than using the output of the cake build system?

Yes, exactly.

@lewissbaker lewissbaker merged commit a19b13b into lewissbaker:master Mar 27, 2018
@Uran198 Uran198 deleted the redef_warnings branch March 28, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants