refactor(v2): improve regex matching code-block title (facebook#3671)

lex111 · Nov 2, 2020 · 3242549 · 3242549
1 parent 398af74
commit 3242549
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.tsx b/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.tsx
@@ -84,7 +84,7 @@ const highlightDirectiveRegex = (lang) => {
       return getHighlightDirectiveRegex();
   }
 };
-const codeBlockTitleRegex = /title=".*"/;
+const codeBlockTitleRegex = /(?<=title=").*(?=")/;
 
 export default ({
   children,
@@ -125,9 +125,7 @@ export default ({
     // Tested above
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     codeBlockTitle = metastring
-      .match(codeBlockTitleRegex)![0]
-      .split('title=')[1]
-      .replace(/"+/g, '');
+      .match(codeBlockTitleRegex)![0];
   }
 
   let language =