Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] about perf code #7

Open
vtorri opened this issue Aug 3, 2018 · 4 comments
Open

[discussion] about perf code #7

vtorri opened this issue Aug 3, 2018 · 4 comments
Labels
discussion Discussion of questions, plans and other things

Comments

@vtorri
Copy link
Contributor

vtorri commented Aug 3, 2018

in perf.h, 2 declarations seem unnecessary to me : lexbor_perf_frequency() and lexbor_perf_clock()

perf code is used to compute time in second of a part of code. So i would say that only lexbor_perf_in_sec() is necessary and the 2 functions above could be static in perf.c

@vtorri vtorri mentioned this issue Aug 3, 2018
@tcheko
Copy link

tcheko commented Aug 22, 2018

There is also some asm directive with x86 instructions in lexbor_perf_clock(). This part should be made arch specific.

@lexborisov lexborisov added the discussion Discussion of questions, plans and other things label Aug 23, 2018
@lexborisov
Copy link
Member

@vtorri
Removed two functions, see commit.

@lexborisov
Copy link
Member

lexborisov commented Aug 25, 2018

@tcheko
Perhaps, it is worth to abandon the ASM instructions and use only the native methods in each OS.
Some like a monotonic in linux.

@vtorri
Copy link
Contributor Author

vtorri commented Aug 26, 2018

fixed in f78290f

it remains the asm code

GerHobbelt pushed a commit to GerHobbelt/lexbor that referenced this issue Jan 26, 2024
…giri-1.11.0

Bump nokogiri from 1.10.8 to 1.11.0 in /bench
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion of questions, plans and other things
Projects
None yet
Development

No branches or pull requests

3 participants