Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce JWTExpiredEvent #230

Merged

Conversation

chalasr
Copy link
Collaborator

@chalasr chalasr commented Aug 27, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations no
Fixed tickets #223
Tests pass? yes

This is IMHO quite useful to have.

I'm not sure the proposed approach of passing the invalid payload to the event and make it accessible from for reusing it is something safe, I would like to have feedbacks.
Also I'm not really satisfied of the implementation here, looking for suggestions.

Target #184 for complete testing.

@chalasr chalasr added this to the 2.0 milestone Aug 27, 2016
@chalasr chalasr force-pushed the catchable_expired_token branch 4 times, most recently from f779216 to 058f66f Compare August 27, 2016 14:46
@chalasr chalasr force-pushed the guard_jwt_authenticator branch 2 times, most recently from 64eb651 to b64db93 Compare August 28, 2016 11:27
@chalasr chalasr force-pushed the guard_jwt_authenticator branch 2 times, most recently from 09c585c to 130f6ac Compare August 28, 2016 12:16
@chalasr chalasr force-pushed the guard_jwt_authenticator branch 2 times, most recently from af51f33 to 73ebbac Compare August 28, 2016 12:50
@chalasr chalasr force-pushed the catchable_expired_token branch 2 times, most recently from cf2861d to dacdf52 Compare September 2, 2016 23:06
    * Refactor encoder exceptions
    * Define encode/decode exceptions message from Encoder, Remove auto-renew behavior
    * Code quality tweeaks
@chalasr chalasr merged commit 8680a1c into lexik:guard_jwt_authenticator Sep 2, 2016
chalasr added a commit that referenced this pull request Sep 2, 2016
This PR was merged into the guard_jwt_authenticator branch.

Discussion
----------

| Q             | A    |
|---------------|------|
| Bug fix?      | no  |
| New feature?  | yes |
| BC breaks?    | no  |
| Deprecations | no |
| Fixed tickets | #223 |
| Tests pass?   | yes  |

This is IMHO quite useful to have.

I'm not sure the proposed approach of passing the invalid payload to the event and make it accessible from for reusing it is something safe, I would like to have feedbacks.
Also I'm not really satisfied of the implementation here, looking for suggestions.

Target #184 for complete testing.

Commits
-------

8680a1c Introduce JWTExpiredEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant