Introduce JWTExpiredEvent #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
catchable_expired_token
branch
4 times, most recently
from
f779216
to
058f66f
Compare
chalasr
force-pushed
the
guard_jwt_authenticator
branch
2 times, most recently
from
64eb651
to
b64db93
Compare
chalasr
force-pushed
the
catchable_expired_token
branch
from
058f66f
to
8547b55
Compare
chalasr
force-pushed
the
guard_jwt_authenticator
branch
2 times, most recently
from
09c585c
to
130f6ac
Compare
chalasr
force-pushed
the
catchable_expired_token
branch
from
8547b55
to
4d5ae83
Compare
chalasr
force-pushed
the
guard_jwt_authenticator
branch
2 times, most recently
from
af51f33
to
73ebbac
Compare
chalasr
force-pushed
the
catchable_expired_token
branch
2 times, most recently
from
cf2861d
to
dacdf52
Compare
* Refactor encoder exceptions
* Define encode/decode exceptions message from Encoder, Remove auto-renew behavior
* Code quality tweeaks
chalasr
force-pushed
the
catchable_expired_token
branch
from
dacdf52
to
8680a1c
Compare
chalasr
added a commit
that referenced
this pull request
Sep 2, 2016
This PR was merged into the guard_jwt_authenticator branch. Discussion ---------- | Q | A | |---------------|------| | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations | no | | Fixed tickets | #223 | | Tests pass? | yes | This is IMHO quite useful to have. I'm not sure the proposed approach of passing the invalid payload to the event and make it accessible from for reusing it is something safe, I would like to have feedbacks. Also I'm not really satisfied of the implementation here, looking for suggestions. Target #184 for complete testing. Commits ------- 8680a1c Introduce JWTExpiredEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is IMHO quite useful to have.
I'm not sure the proposed approach of passing the invalid payload to the event and make it accessible from for reusing it is something safe, I would like to have feedbacks.
Also I'm not really satisfied of the implementation here, looking for suggestions.
Target #184 for complete testing.