Fix missing implements breaking JWT header alteration #542

tucksaun · 2018-08-02T18:48:47Z

Otherwise headers are not get from the event, see

LexikJWTAuthenticationBundle/Services/JWTManager.php

Lines 61 to 65 in 85b0578

    
           if ($this->jwtEncoder instanceof HeaderAwareJWTEncoderInterface) { 
        
               $jwtString = $this->jwtEncoder->encode($jwtCreatedEvent->getData(), $jwtCreatedEvent->getHeader()); 
        
           } else { 
        
               $jwtString = $this->jwtEncoder->encode($jwtCreatedEvent->getData()); 
        
           }

chalasr · 2018-08-02T19:24:27Z

Good catch, thanks @tucksaun.

…aun) This PR was merged into the 2.x-dev branch. Discussion ---------- Fix missing implements breaking JWT header alteration Otherwise headers are not get from the event, see https://github.com/lexik/LexikJWTAuthenticationBundle/blob/85b05784fbad7d6435626915edeeb55ed0bcd6a7/Services/JWTManager.php#L61-L65 Commits ------- 53755d0 Fix missing implements breaking JWT header alteration

Spomky · 2018-08-02T19:25:29Z

Excellent.Missed that none when I submitted the PR

chalasr · 2018-08-02T19:36:29Z

Released in v2.5.4

Fix missing implements breaking JWT header alteration

53755d0

tucksaun force-pushed the missing-implements branch from 3331c93 to 53755d0 Compare August 2, 2018 18:53

fabpot approved these changes Aug 2, 2018

View reviewed changes

chalasr approved these changes Aug 2, 2018

View reviewed changes

chalasr merged commit 53755d0 into lexik:master Aug 2, 2018

tucksaun deleted the missing-implements branch December 7, 2018 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing implements breaking JWT header alteration #542

Fix missing implements breaking JWT header alteration #542

tucksaun commented Aug 2, 2018 •

edited

chalasr commented Aug 2, 2018

Spomky commented Aug 2, 2018

chalasr commented Aug 2, 2018

	if ($this->jwtEncoder instanceof HeaderAwareJWTEncoderInterface) {
	$jwtString = $this->jwtEncoder->encode($jwtCreatedEvent->getData(), $jwtCreatedEvent->getHeader());
	} else {
	$jwtString = $this->jwtEncoder->encode($jwtCreatedEvent->getData());
	}

Fix missing implements breaking JWT header alteration #542

Fix missing implements breaking JWT header alteration #542

Conversation

tucksaun commented Aug 2, 2018 • edited

chalasr commented Aug 2, 2018

Spomky commented Aug 2, 2018

chalasr commented Aug 2, 2018

tucksaun commented Aug 2, 2018 •

edited