This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Support for Symfony Events #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the translator.master NOTE: Also made lock and unlock `final` so that its not possible for people to extend the locking and unlocking process and break event from being thrown
|
Hmm... I'm pretty sure those failed tests are not something I've done (they appear to fail on other pull requests too) but I'm happy to fix if I'm wrong about that. ;-) |
…a little 'out of scope' for the changes in this pull request, so I've shut up the warning for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I've added a some simple events to the bundle so that people can trigger other actions from locking and unlocking the site.
Use case: Currently, when I take a site off-line, all external monitoring goes red and people start shouting at me about the site being down. So I want to be able to disable external systems on successfully locking the site and then enable them once the site is back.
Currently, the events are pretty rudimentary, but could be extended to contain extra information if required in the future.
Hope you find this useful and accept the pull. ;-)