Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of 2.7 translator profiler #165

Closed
7 of 11 tasks
rvanlaak opened this issue Aug 31, 2015 · 11 comments
Closed
7 of 11 tasks

Integration of 2.7 translator profiler #165

rvanlaak opened this issue Aug 31, 2015 · 11 comments

Comments

@rvanlaak
Copy link
Contributor

The Symfony 2.7 LTS release contains new features that integrate the profiler with the translator. A new list_missing_translations branch was created to start making use of these features. There still are some TODOs left:

  • translation overview page
    • show grid with number of translated items per domain per language
    • add some sort of percentage, can we use the highest number of translation items as 100%?
    • show message if there are no translations
  • translation page
    • get translations based on profiler token
    • show message if there are no translations
    • hide profiles after clicking 'all' button
    • somehow improve UX of the language checkboxes
  • translations of new labels
  • tests & docs
@rvanlaak
Copy link
Contributor Author

ping @cedric-g are we almost there? 👍

@cedric-g
Copy link
Collaborator

not yet, I will try to find some time next week to work a bit on the bundle.

@rvanlaak
Copy link
Contributor Author

Was thinking about a decorator for the translator and the translation Twig extension, so we can integrate it with the grid. What about wrapping the translations in a span, and linking it with the search feature of the grid? That would allow live translations 👍

@cedric-g
Copy link
Collaborator

Why not, we can add an optional parameter to pass a trans-unit's id.

@rvanlaak
Copy link
Contributor Author

Does the ng grid already allow filtering on a get-parameter?

@cedric-g
Copy link
Collaborator

We can get the value in the grid action and pass it to the ng-grid (and so don't call the list action in this case)

@cedric-g
Copy link
Collaborator

cedric-g commented Oct 6, 2015

@rvanlaak I've added some percentages on the overview, it looks like:
overview

@rvanlaak
Copy link
Contributor Author

rvanlaak commented Oct 6, 2015

Looks awesome! Will take a look at it later this week

@cedric-g
Copy link
Collaborator

cedric-g commented Nov 6, 2015

@rvanlaak I think I will merge the branch and create a new 3.1 version, others features/improvements can be done later.

@rvanlaak
Copy link
Contributor Author

rvanlaak commented Nov 6, 2015

Sound like a great plan to me

@rvanlaak
Copy link
Contributor Author

@cedric-g this seems to be merged and released now right? Feel free to close this issue.

Maybe add some comments about it to CHANGELOG.md? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants