-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of 2.7 translator profiler #165
Comments
ping @cedric-g are we almost there? 👍 |
not yet, I will try to find some time next week to work a bit on the bundle. |
Was thinking about a decorator for the translator and the translation Twig extension, so we can integrate it with the grid. What about wrapping the translations in a span, and linking it with the search feature of the grid? That would allow live translations 👍 |
Why not, we can add an optional parameter to pass a trans-unit's id. |
Does the ng grid already allow filtering on a get-parameter? |
We can get the value in the grid action and pass it to the ng-grid (and so don't call the list action in this case) |
@rvanlaak I've added some percentages on the overview, it looks like: |
Looks awesome! Will take a look at it later this week |
@rvanlaak I think I will merge the branch and create a new 3.1 version, others features/improvements can be done later. |
Sound like a great plan to me |
@cedric-g this seems to be merged and released now right? Feel free to close this issue. Maybe add some comments about it to CHANGELOG.md? 😉 |
The Symfony 2.7 LTS release contains new features that integrate the profiler with the translator. A new list_missing_translations branch was created to start making use of these features. There still are some TODOs left:
The text was updated successfully, but these errors were encountered: