Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebUI] Filter on profiler token #67

Open
rvanlaak opened this issue Jan 4, 2017 · 6 comments
Open

[WebUI] Filter on profiler token #67

rvanlaak opened this issue Jan 4, 2017 · 6 comments

Comments

@rvanlaak
Copy link
Member

rvanlaak commented Jan 4, 2017

Would be great if the web UI would be able to filter on a profiler token. Since 2.7 the profiler collects all translations: symfony/symfony#14003

  • allow to filter the shown translations based on a profiler token
  • show <select> with the last 10 profile tokens
  • show button to load the last profile token
  • add link in profiler itself that directly filters on the translations of the visited token

Also see lexik/LexikTranslationBundle#165

@rvanlaak
Copy link
Member Author

rvanlaak commented Jan 4, 2017

Yes I know it's not part of the WebUI, but that basically is my feature request; being able to filter based on the profiler tokens. Could be an easy way for developers to do translations; navigate a request, and thereafter "goto last request" in the Web UI.

@Nyholm
Copy link
Member

Nyholm commented Jan 4, 2017

Im saying that you can do that already. But you have to use the symfony profiler integration.

The profiler integration provides that exact functionality and the WebUI is for editing all your translations.

If one would merge the two we have to duplicate the functionality from Symfony where they show/select profiler tokens and load the data collected.

@rvanlaak
Copy link
Member Author

rvanlaak commented Jan 4, 2017

The main reason for this feature request is that the WebUI also shows the translations in the other locales. Yes I agree that functionality is comparable, but I think that the WebUI eventually would be able to give a better translation experience as the profiler would be able to do.

So it might be a nice discussion to determine what place is preferable for new features, the webUI or the profiler 👍

@Nyholm
Copy link
Member

Nyholm commented Jan 4, 2017

WebUI also shows the translations in the other locales.

Ah, I see. I actually had that problem. I usually go to Loco and translate new strings there.

👍

@rvanlaak
Copy link
Member Author

rvanlaak commented Jan 4, 2017

I'm still in the process of trying to find out whether we would still need an external translation service. As we really prefer translating based on requests, I started submitting feature requests based on that. I hope that we eventually don't need an "extra" piece of software for our translations :)

So, yes I agree that some features duplicate existing behavior (profiler vs. WebUI), but I don't think they would block each other. Eventually from the perspective of the translator this integration between both should work seamlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants