Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow for framerates less than 4 fps #114

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

dlitz
Copy link
Contributor

@dlitz dlitz commented Mar 28, 2024

This increases m_FrameDurationMs from 8 to 16 bits.

Using 8 bits for m_FrameDurationMs meant it would overflow above 255ms, so attempting to use framerates below 4 would trigger frame refreshes too often.

This increases m_FrameDurationMs from 8 to 16 bits.

Using 8 bits for m_FrameDurationMs meant it would overflow above 255ms,
so attempting to use framerates below 4 would trigger frame refreshes
too often.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lexus2k lexus2k merged commit 62d373c into lexus2k:master Mar 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants