Fix cold start issues, add documentation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabani1
approved these changes
Oct 4, 2023
jnnnthnn
added a commit
that referenced
this pull request
Oct 7, 2023
# What changed Avoids committing Postgres build steps to tagged image. # Why We were running into issues with the Postgres container where rebuilds wouldn't be idempotent. This was addressed in #1 by checking for idempotency issues, but that didn't address the core issue. The core issue is that by specifying `image` in the docker compose file, we'd tag the _built_ image as the source `postgres:15.4-bullseye` image ([docs](https://github.com/compose-spec/compose-spec/blob/master/spec.md#image)). # Test plan Running `docker-compose build db_postgres` twice in a row shouldn't lead to any issues.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing installation instructions are somewhat stale. This documents the steps necessary to set up a fresh install of Lexy, and tweaks some of the configuration files to make things more reproducible.
Works on my machine.