Invalid invalid type handling

[scaytrase]

If data type does not match schema code still tries to utilize it as a scalar value. moreother it tries utilize value itself rather than type, and this can lead to huge error texts

notice: "Array to string conversion in /data/www/content.leos.lamoda.ru/vendor/lezhnev74/openapi-psr7-validator/src/Schema/Keywords/Type.php on line 81"

I'll try to fix it

[scaytrase]

Also some questions @lezhnev74

openapi-psr7-validator/src/Schema/Keywords/Type.php

Line 70 in aa1cef2

if (! isset($this->parentSchema->items)) {

This line should some kind of schema validation step, not data validation. It's rather strange to decline data here if schema is invalid. Probably this should go to cebe/php-openapi instead

openapi-psr7-validator/src/Schema/Keywords/Type.php

Line 67 in aa1cef2

if (count($data) && ! (is_array($data) && ArrayHelper::isAssoc($data))) {

counting data befor validating its type is unsafe (especially for php 7.2). why we expecting items in data at all?

[scaytrase]

Also schema validation is duplicated here

openapi-psr7-validator/src/Schema/Keywords/Type.php

Line 49 in aa1cef2

])->stringType()->assert($type);

and here

openapi-psr7-validator/src/Schema/Keywords/Type.php

Line 90 in aa1cef2

throw new Exception("Type '%s' is unexpected", $type);

I hope we can leave second only, it's more obvious

[lezhnev74]

Great points!

1. $this->parentSchema->items.
   Agree, this is too defensive. This should be delegated to the underlying package.
2. count($data) && ! (is_array($data) && ArrayHelper::isAssoc($data))
   This must make sure that the data is an array, and it has no string keys (which makes it a dictionary in terms of JSON). What would be a better check here? Ah, I jsut saw the PR. This code solves the problem: if (! is_array($data) || ArrayHelper::isAssoc($data)) {...
3. Also schema validation is duplicated here.
   Agreed. Let's leave just switch statement here. Again, sometimes my code is over defensive.

[scaytrase]

2. everything but counting is ok. counting is unsafe and really not needed. to check vector against array is_array($data) && !ArrayHelper::isAssoc($data) is enough. Counting on non countable would fail in 7.2+

https://php.net/manual/en/migration72.incompatible.php#migration72.incompatible.warn-on-non-countable-types

[scaytrase]

For 1 and 3 I can update #21 removing these additional checks

[lezhnev74]

Please, go ahead, sounds good!

[scaytrase]

Done. Raised one more question in PR