Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use data type only for type exceptions #21

Merged
merged 6 commits into from
May 16, 2019
Merged

Use data type only for type exceptions #21

merged 6 commits into from
May 16, 2019

Conversation

scaytrase
Copy link
Contributor

Fixes #19

@scaytrase scaytrase mentioned this pull request May 16, 2019
Closed
@lezhnev74
Add quotes for readability
ae3048b 
Add fixes to conform to DOctrine coding style
@lezhnev74
Copy link
Owner

Pushed some minor fixes to pass Doctrine coding style checks.

@scaytrase
Copy link
Contributor Author

Looks like every comment is addressed

@lezhnev74 lezhnev74 merged commit cdba9dd into lezhnev74:master May 16, 2019
@lezhnev74
Copy link
Owner

Merged. Gonna update Readme with mentions of a new exception class.

@scaytrase
Copy link
Contributor Author

Is it needed? It's currently being rethrown as ValidationKeywordFailed as before

@scaytrase scaytrase deleted the bugfix/use-data-type-only-for-type-exceptions branch May 16, 2019 14:34
@lezhnev74
Copy link
Owner

Well, currently you should be able to evaluate "previous" exceptions chain. So it could be valuable in some situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezhnev74 lezhnev74 lezhnev74 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid invalid type handling
2 participants
@scaytrase @lezhnev74