Skip to content

Commit

Permalink
[Vis Augmenter] Update base vis height in view events flyout (opensea…
Browse files Browse the repository at this point in the history
…rch-project#4535)

* [Vis Augmenter] Update base vis height in view events flyout

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Update CHANGELOG

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
  • Loading branch information
ohltyler authored and lezzago committed Jul 10, 2023
1 parent 3b9d45f commit 5dc9575
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Saved Object Service] Add Repository Factory Provider ([#4149](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4149))
- Enable plugins to augment visualizations with additional data and context ([#4361](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4361))
- New management overview page and rename stack management to dashboard management ([#4287](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4287))
- [Vis Augmenter] Update base vis height in view events flyout ([#4535](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4535))


### 🐛 Bug Fixes
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
$vis-description-width: 200px;
$event-vis-height: 55px;
$timeline-panel-height: 100px;
$timeline-panel-height: 90px;
$content-padding-top: 110px; // Padding needed within view events flyout content to sit comfortably below flyout header
$date-range-height: 45px; // Static height we want for the date range picker component
$error-icon-padding-right: -8px; // This is so the error icon is aligned consistent with the event count icons
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,14 @@ export function ViewEventsFlyout(props: Props) {
>
<DateRangeItem timeRange={timeRange as TimeRange} reload={reload} />
</EuiFlexItem>
<EuiFlexItem className="view-events-flyout__contentPanel" grow={5}>
<EuiFlexItem
className="view-events-flyout__contentPanel"
grow={7}
style={{ maxHeight: '40vh' }}
>
<BaseVisItem embeddable={visEmbeddable as VisualizeEmbeddable} />
</EuiFlexItem>
<EuiFlexItem className="view-events-flyout__contentPanel show-y-scroll" grow={5}>
<EuiFlexItem className="view-events-flyout__contentPanel show-y-scroll" grow={3}>
<EventsPanel
eventVisEmbeddablesMap={eventVisEmbeddablesMap as EventVisEmbeddablesMap}
/>
Expand Down

0 comments on commit 5dc9575

Please sign in to comment.