Fix-patch 9.1 #2941
Merged
Fix-patch 9.1 #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We retry make pkgs several times but do not check was it succeed or not, let's check this and exit immediately. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 813e91f)
With enforced checking from linuxkit (linuxkit/linuxkit#3875) we must be more accurate with generated files and add them to gitignore Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit bcbbfaa)
We run eve builders in parallel so no need for distinct build and build and push steps. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 7120724)
Seems we have a bug in linuxkit which blocks us from publish artifacts Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 81ce116)
giggsoff
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by @giggsoff "We cannot use linuxkit pkg push after pkg build --pull if we define different docker flags in commands (and right now we have problems in publish workflow).
Let's remove pkg build --pull step and wait for changes from linuxkit/linuxkit#3876"
Also PR includes explicit exit from publish workflow in case of error in our retry logic.