Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
With the earlier PR #3863 , for
pkg build
, if the image exists in the remote registry we don't bother pulling it unless they explicitly requested--pull
. This is much more efficient.However, this might break
pkg push
in the following scenario:lkt pkg push pkg/foo
- How I did it
Added logic to check if we built anything or found anything locally.
I would add that there might be a cleaner way to do this, specifically just check before pushing, "do we have anything in cache". The net result, though, is the same.
- How to verify it
CI
- Description for the changelog
Handle
pkg push
when nothing is built or pulled.