Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubevirt: move containerd-user root to persist #3877

Merged

Conversation

andrewd-zededa
Copy link
Contributor

New kubevirt storage layout has /var/lib slimmed
down to 10GB only for k3s.
containerd-user root requires a move to persist.

Part 1 of the breakup of now-draft PR: #3838.

New kubevirt storage layout has /var/lib slimmed
down to 10GB only for k3s.
containerd-user root requires a move to persist.

Signed-off-by: Andrew Durbin <andrewd@zededa.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will this require a flag day reinstall for all existing devices running kubevirt due to the path name change? If so can you prepare a message for LF-Edge slack and email.

@andrewd-zededa
Copy link
Contributor Author

@eriknordmark yes this would require a fresh usb reinstall to move forward from a build with the previous path . I can prepare a message

@andrewd-zededa
Copy link
Contributor Author

@eriknordmark

I don't currently have an account with access to the lf edge slack. I'll try to request access. For now here is a potential draft message for the community:

Storage layout change to kubevirt EVE-OS containerd images.

This is an announcement to any users of the kubevirt build of EVE-OS. This prerelease image is seeing a change to the storage layout
which moves user containerd images from its default inside k3s subpath /var/lib/rancher/k3s/agent/containerd/ to the standard EVE path
of /persist/vault/containerd. This change will be included as a part of PR3877.

The change will impact any currently installed kubevirt image and require those nodes to be reinstalled. Upgrades are not supported from a build before this change to a build after this change.

@eriknordmark
Copy link
Contributor

@eriknordmark

I don't currently have an account with access to the lf edge slack. I'll try to request access.

I emailed you an invite. (I don't recall whether you have to create a login on the LF-Edge webpages/wikis to be able to join slack.)

For now here is a potential draft message for the community:

Storage layout change to kubevirt EVE-OS containerd images.
This is an announcement to any users of the kubevirt build of EVE-OS.

It would make sense to specify who should worry (developers) and how to tell you are running kubevirt (the EVE release string contains "kubevirt" as opposed to "kvm" or "xen").

This prerelease image is seeing a change to the storage layout

which moves user containerd images from its default inside k3s subpath /var/lib/rancher/k3s/agent/containerd/ to the standard EVE path
of /persist/vault/containerd. This change will be included as a part of PR3877.
The change will impact any currently installed kubevirt image and require those nodes to be reinstalled. Upgrades are not supported from a build before this change to a build after this change.

@andrewd-zededa
Copy link
Contributor Author

Thanks @eriknordmark. Here is my latest draft. If this looks alright should I post it to the eve channel on lf-edge slack?

Storage layout change to kubevirt EVE-OS containerd images.

This is an announcement to any developers of the kubevirt build of EVE-OS. This prerelease image is seeing a change to the storage layout which moves user containerd images from its default inside k3s subpath /var/lib/rancher/k3s/agent/containerd/ to the standard EVE path of /persist/vault/containerd. This change will be included as a part of PR3877. The kubevirt build are only those identified by presence of the string "kubevirt" in the version string which can be found either from the output of the "eve version" command or through the contents of the /hostfs/etc/eve-release and /run/eve-hv-type files.

The change will impact any currently installed kubevirt image and require those nodes to be reinstalled. Upgrades are not supported from a build before this change to a build after this change.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kick eden

@andrewd-zededa
Copy link
Contributor Author

@eriknordmark @rouming Looks like the latest failed CI checks are due to build-jet comms issues and are on the kvm build anyways which this PR did not change.

Otherwise, is this go for merging?

@eriknordmark eriknordmark merged commit 8098cc7 into lf-edge:master Apr 24, 2024
72 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants